CEC-5135: remove prop from useEffect deps (#459)

* resolve localStorage race condition

* fix

* fix

* CEC-5135: remove prop from deps

* update test
This commit is contained in:
Tristan Timblin
2023-10-03 17:10:54 -07:00
committed by GitHub
parent e5ccb23443
commit eae44c9249
4 changed files with 32 additions and 36 deletions

View File

@@ -18,10 +18,10 @@ import useStyles from "../../useStyles";
const MainForm = () => {
const classes = useStyles();
const [online, setOnline] = useState(false);
const [onlineHMI, setOnlineHMI] = useState(false);
const [online, setOnline] = useState(null);
const [onlineHMI, setOnlineHMI] = useState(null);
const [selectedVins, setSelectedVins] = useState([]);
const { vins, search, query, setQuery, loading } = useQuery();
const { payload, query, setQuery, loading } = useQuery();
const { setTitle, setSitePath } = useStatusContext();
const {
token: {
@@ -36,7 +36,7 @@ const MainForm = () => {
};
const handleOnline = (event) => {
setOnline(event.target.checked);
setOnline(event.target.checked || null);
};
const handleSelectAll = (cars) => {
@@ -53,7 +53,7 @@ const MainForm = () => {
};
const handleOnlineHMI = (event) => {
setOnlineHMI(event.target.checked);
setOnlineHMI(event.target.checked || null);
};
useEffect(() => {
@@ -105,10 +105,9 @@ const MainForm = () => {
token={token}
multiSelect
search={{
search,
vins,
online: online ? true : null,
online_hmi: onlineHMI ? true : null,
...payload,
online,
online_hmi: onlineHMI,
}}
selected={selectedVins}
onSelect={handleSelect}