From d58369def62a572e78177fcf16cd582344df1ae0 Mon Sep 17 00:00:00 2001
From: Tristan Timblin <ttimblin@fiskerinc.com>
Date: Wed, 13 Dec 2023 10:26:33 -0800
Subject: [PATCH] CEC-5436: update default sorting of tables (#490)

* CEC-5436: add release_notes, update_duration, and max_attempts to manifest update form

* CEC-5436: reverse field order

* CEC-5436: sort vehicles by last updated

* CEC-5431: increase concurrency (#487)

* increase concurrency

* fix unmounted component leak
---
 .../App/__snapshots__/App.test.js.snap        | 54 +++++++++----------
 .../List/__snapshots__/index.test.jsx.snap    | 18 +++----
 .../Controls/CarSelectionTable/index.jsx      |  4 +-
 .../Controls/IssueSelectionTable/index.jsx    |  2 +-
 .../Add/__snapshots__/index.test.jsx.snap     | 18 +++----
 src/components/Manifest/List/index.jsx        |  2 +-
 src/components/Manifest/Status/index.jsx      |  2 +-
 7 files changed, 50 insertions(+), 50 deletions(-)

diff --git a/src/components/App/__snapshots__/App.test.js.snap b/src/components/App/__snapshots__/App.test.js.snap
index 8012769..ad6d052 100644
--- a/src/components/App/__snapshots__/App.test.js.snap
+++ b/src/components/App/__snapshots__/App.test.js.snap
@@ -3427,7 +3427,7 @@ exports[`App Route /issues authenticated 1`] = `
                         </span>
                       </th>
                       <th
-                        aria-sort="ascending"
+                        aria-sort="descending"
                         class="MuiTableCell-root MuiTableCell-head MuiTableCell-alignCenter"
                         scope="col"
                       >
@@ -3441,11 +3441,11 @@ exports[`App Route /issues authenticated 1`] = `
                           <span
                             class="makeStyles-hiddenSortSpan-0"
                           >
-                            sorted ascending
+                            sorted descending
                           </span>
                           <svg
                             aria-hidden="true"
-                            class="MuiSvgIcon-root MuiTableSortLabel-icon MuiTableSortLabel-iconDirectionAsc"
+                            class="MuiSvgIcon-root MuiTableSortLabel-icon MuiTableSortLabel-iconDirectionDesc"
                             focusable="false"
                             viewBox="0 0 24 24"
                           >
@@ -4468,22 +4468,16 @@ exports[`App Route /package-deploy authenticated 1`] = `
                               </span>
                             </th>
                             <th
-                              aria-sort="ascending"
                               class="MuiTableCell-root MuiTableCell-head MuiTableCell-alignCenter"
                               scope="col"
                             >
                               <span
                                 aria-disabled="false"
-                                class="MuiButtonBase-root MuiTableSortLabel-root MuiTableSortLabel-active"
+                                class="MuiButtonBase-root MuiTableSortLabel-root"
                                 role="button"
                                 tabindex="0"
                               >
                                 VIN
-                                <span
-                                  class="makeStyles-hiddenSortSpan-0"
-                                >
-                                  sorted ascending
-                                </span>
                                 <svg
                                   aria-hidden="true"
                                   class="MuiSvgIcon-root MuiTableSortLabel-icon MuiTableSortLabel-iconDirectionAsc"
@@ -4589,19 +4583,25 @@ exports[`App Route /package-deploy authenticated 1`] = `
                               </span>
                             </th>
                             <th
+                              aria-sort="descending"
                               class="MuiTableCell-root MuiTableCell-head MuiTableCell-alignCenter"
                               scope="col"
                             >
                               <span
                                 aria-disabled="false"
-                                class="MuiButtonBase-root MuiTableSortLabel-root"
+                                class="MuiButtonBase-root MuiTableSortLabel-root MuiTableSortLabel-active"
                                 role="button"
                                 tabindex="0"
                               >
                                 Updated
+                                <span
+                                  class="makeStyles-hiddenSortSpan-0"
+                                >
+                                  sorted descending
+                                </span>
                                 <svg
                                   aria-hidden="true"
-                                  class="MuiSvgIcon-root MuiTableSortLabel-icon MuiTableSortLabel-iconDirectionAsc"
+                                  class="MuiSvgIcon-root MuiTableSortLabel-icon MuiTableSortLabel-iconDirectionDesc"
                                   focusable="false"
                                   viewBox="0 0 24 24"
                                 >
@@ -5406,7 +5406,7 @@ exports[`App Route /package-status authenticated 1`] = `
                         </span>
                       </th>
                       <th
-                        aria-sort="ascending"
+                        aria-sort="descending"
                         class="MuiTableCell-root MuiTableCell-head MuiTableCell-alignCenter"
                         scope="col"
                       >
@@ -5420,11 +5420,11 @@ exports[`App Route /package-status authenticated 1`] = `
                           <span
                             class="makeStyles-hiddenSortSpan-0"
                           >
-                            sorted ascending
+                            sorted descending
                           </span>
                           <svg
                             aria-hidden="true"
-                            class="MuiSvgIcon-root MuiTableSortLabel-icon MuiTableSortLabel-iconDirectionAsc"
+                            class="MuiSvgIcon-root MuiTableSortLabel-icon MuiTableSortLabel-iconDirectionDesc"
                             focusable="false"
                             viewBox="0 0 24 24"
                           >
@@ -6590,7 +6590,7 @@ exports[`App Route /packages authenticated 1`] = `
                       </span>
                     </th>
                     <th
-                      aria-sort="ascending"
+                      aria-sort="descending"
                       class="MuiTableCell-root MuiTableCell-head MuiTableCell-alignCenter"
                       scope="col"
                     >
@@ -6604,11 +6604,11 @@ exports[`App Route /packages authenticated 1`] = `
                         <span
                           class="makeStyles-hiddenSortSpan-0"
                         >
-                          sorted ascending
+                          sorted descending
                         </span>
                         <svg
                           aria-hidden="true"
-                          class="MuiSvgIcon-root MuiTableSortLabel-icon MuiTableSortLabel-iconDirectionAsc"
+                          class="MuiSvgIcon-root MuiTableSortLabel-icon MuiTableSortLabel-iconDirectionDesc"
                           focusable="false"
                           viewBox="0 0 24 24"
                         >
@@ -12678,22 +12678,16 @@ exports[`App Route /vehicles authenticated 1`] = `
                         </span>
                       </th>
                       <th
-                        aria-sort="ascending"
                         class="MuiTableCell-root MuiTableCell-head MuiTableCell-alignCenter"
                         scope="col"
                       >
                         <span
                           aria-disabled="false"
-                          class="MuiButtonBase-root MuiTableSortLabel-root MuiTableSortLabel-active"
+                          class="MuiButtonBase-root MuiTableSortLabel-root"
                           role="button"
                           tabindex="0"
                         >
                           VIN
-                          <span
-                            class="makeStyles-hiddenSortSpan-0"
-                          >
-                            sorted ascending
-                          </span>
                           <svg
                             aria-hidden="true"
                             class="MuiSvgIcon-root MuiTableSortLabel-icon MuiTableSortLabel-iconDirectionAsc"
@@ -12799,19 +12793,25 @@ exports[`App Route /vehicles authenticated 1`] = `
                         </span>
                       </th>
                       <th
+                        aria-sort="descending"
                         class="MuiTableCell-root MuiTableCell-head MuiTableCell-alignCenter"
                         scope="col"
                       >
                         <span
                           aria-disabled="false"
-                          class="MuiButtonBase-root MuiTableSortLabel-root"
+                          class="MuiButtonBase-root MuiTableSortLabel-root MuiTableSortLabel-active"
                           role="button"
                           tabindex="0"
                         >
                           Updated
+                          <span
+                            class="makeStyles-hiddenSortSpan-0"
+                          >
+                            sorted descending
+                          </span>
                           <svg
                             aria-hidden="true"
-                            class="MuiSvgIcon-root MuiTableSortLabel-icon MuiTableSortLabel-iconDirectionAsc"
+                            class="MuiSvgIcon-root MuiTableSortLabel-icon MuiTableSortLabel-iconDirectionDesc"
                             focusable="false"
                             viewBox="0 0 24 24"
                           >
diff --git a/src/components/Cars/List/__snapshots__/index.test.jsx.snap b/src/components/Cars/List/__snapshots__/index.test.jsx.snap
index 2b53f6d..6a42fdd 100644
--- a/src/components/Cars/List/__snapshots__/index.test.jsx.snap
+++ b/src/components/Cars/List/__snapshots__/index.test.jsx.snap
@@ -173,22 +173,16 @@ exports[`VehicleTable Render 1`] = `
                       </span>
                     </th>
                     <th
-                      aria-sort="ascending"
                       class="MuiTableCell-root MuiTableCell-head MuiTableCell-alignCenter"
                       scope="col"
                     >
                       <span
                         aria-disabled="false"
-                        class="MuiButtonBase-root MuiTableSortLabel-root MuiTableSortLabel-active"
+                        class="MuiButtonBase-root MuiTableSortLabel-root"
                         role="button"
                         tabindex="0"
                       >
                         VIN
-                        <span
-                          class="makeStyles-hiddenSortSpan-0"
-                        >
-                          sorted ascending
-                        </span>
                         <svg
                           aria-hidden="true"
                           class="MuiSvgIcon-root MuiTableSortLabel-icon MuiTableSortLabel-iconDirectionAsc"
@@ -294,19 +288,25 @@ exports[`VehicleTable Render 1`] = `
                       </span>
                     </th>
                     <th
+                      aria-sort="descending"
                       class="MuiTableCell-root MuiTableCell-head MuiTableCell-alignCenter"
                       scope="col"
                     >
                       <span
                         aria-disabled="false"
-                        class="MuiButtonBase-root MuiTableSortLabel-root"
+                        class="MuiButtonBase-root MuiTableSortLabel-root MuiTableSortLabel-active"
                         role="button"
                         tabindex="0"
                       >
                         Updated
+                        <span
+                          class="makeStyles-hiddenSortSpan-0"
+                        >
+                          sorted descending
+                        </span>
                         <svg
                           aria-hidden="true"
-                          class="MuiSvgIcon-root MuiTableSortLabel-icon MuiTableSortLabel-iconDirectionAsc"
+                          class="MuiSvgIcon-root MuiTableSortLabel-icon MuiTableSortLabel-iconDirectionDesc"
                           focusable="false"
                           viewBox="0 0 24 24"
                         >
diff --git a/src/components/Controls/CarSelectionTable/index.jsx b/src/components/Controls/CarSelectionTable/index.jsx
index 78607c6..3bc04ce 100644
--- a/src/components/Controls/CarSelectionTable/index.jsx
+++ b/src/components/Controls/CarSelectionTable/index.jsx
@@ -63,8 +63,8 @@ const CarSelectionTable = (props) => {
 
   const [pageSize, setPageSize] = useLocalStorage(PAGE_SIZE, 10);
   const [pageIndex, setPageIndex] = useState(0);
-  const [orderBy, setOrderBy] = useState("vin");
-  const [order, setOrder] = useState("asc");
+  const [orderBy, setOrderBy] = useState("updated_at");
+  const [order, setOrder] = useState("desc");
   const { getVehicles, vehicles, totalVehicles } = useVehicleContext();
   const { setMessage } = useStatusContext();
 
diff --git a/src/components/Controls/IssueSelectionTable/index.jsx b/src/components/Controls/IssueSelectionTable/index.jsx
index d892415..fed2754 100644
--- a/src/components/Controls/IssueSelectionTable/index.jsx
+++ b/src/components/Controls/IssueSelectionTable/index.jsx
@@ -64,7 +64,7 @@ const IssueSelectionTable = (props) => {
   const [pageSize, setPageSize] = useLocalStorage(PAGE_SIZE, 10);
   const [pageIndex, setPageIndex] = useState(0);
   const [orderBy, setOrderBy] = useState("created_at");
-  const [order, setOrder] = useState("asc");
+  const [order, setOrder] = useState("desc");
   const { deleteIssue, getIssues, issues, totalIssues = 0 } = useIssueContext();
   const { groups, providers } = useUserContext();
   const { setMessage } = useStatusContext();
diff --git a/src/components/Fleets/Status/Vehicles/Add/__snapshots__/index.test.jsx.snap b/src/components/Fleets/Status/Vehicles/Add/__snapshots__/index.test.jsx.snap
index 3238985..10a1e07 100644
--- a/src/components/Fleets/Status/Vehicles/Add/__snapshots__/index.test.jsx.snap
+++ b/src/components/Fleets/Status/Vehicles/Add/__snapshots__/index.test.jsx.snap
@@ -119,22 +119,16 @@ exports[`FleetVehicleAdd Render 1`] = `
                         </span>
                       </th>
                       <th
-                        aria-sort="ascending"
                         class="MuiTableCell-root MuiTableCell-head MuiTableCell-alignCenter"
                         scope="col"
                       >
                         <span
                           aria-disabled="false"
-                          class="MuiButtonBase-root MuiTableSortLabel-root MuiTableSortLabel-active"
+                          class="MuiButtonBase-root MuiTableSortLabel-root"
                           role="button"
                           tabindex="0"
                         >
                           VIN
-                          <span
-                            class="makeStyles-hiddenSortSpan-0"
-                          >
-                            sorted ascending
-                          </span>
                           <svg
                             aria-hidden="true"
                             class="MuiSvgIcon-root MuiTableSortLabel-icon MuiTableSortLabel-iconDirectionAsc"
@@ -240,19 +234,25 @@ exports[`FleetVehicleAdd Render 1`] = `
                         </span>
                       </th>
                       <th
+                        aria-sort="descending"
                         class="MuiTableCell-root MuiTableCell-head MuiTableCell-alignCenter"
                         scope="col"
                       >
                         <span
                           aria-disabled="false"
-                          class="MuiButtonBase-root MuiTableSortLabel-root"
+                          class="MuiButtonBase-root MuiTableSortLabel-root MuiTableSortLabel-active"
                           role="button"
                           tabindex="0"
                         >
                           Updated
+                          <span
+                            class="makeStyles-hiddenSortSpan-0"
+                          >
+                            sorted descending
+                          </span>
                           <svg
                             aria-hidden="true"
-                            class="MuiSvgIcon-root MuiTableSortLabel-icon MuiTableSortLabel-iconDirectionAsc"
+                            class="MuiSvgIcon-root MuiTableSortLabel-icon MuiTableSortLabel-iconDirectionDesc"
                             focusable="false"
                             viewBox="0 0 24 24"
                           >
diff --git a/src/components/Manifest/List/index.jsx b/src/components/Manifest/List/index.jsx
index 74d1871..b8a9638 100644
--- a/src/components/Manifest/List/index.jsx
+++ b/src/components/Manifest/List/index.jsx
@@ -112,7 +112,7 @@ const MainForm = () => {
   const [pageSize, setPageSize] = useLocalStorage(PAGE_SIZE, 10);
   const [pageIndex, setPageIndex] = useState(0);
   const [orderBy, setOrderBy] = useState("id");
-  const [order, setOrder] = useState("asc");
+  const [order, setOrder] = useState("desc");
   const [search, setSearch] = useLocalStorage("DEPLOYMENT_SEARCH", "");
   const [active, setActive] = useLocalStorage("DEPLOYMENT_TAB_TOGGLE", "software");
 
diff --git a/src/components/Manifest/Status/index.jsx b/src/components/Manifest/Status/index.jsx
index 1482679..e5c5983 100644
--- a/src/components/Manifest/Status/index.jsx
+++ b/src/components/Manifest/Status/index.jsx
@@ -63,7 +63,7 @@ const MainForm = () => {
   const [pageSize, setPageSize] = useLocalStorage(PAGE_SIZE, 10);
   const [pageIndex, setPageIndex] = useState(0);
   const [orderBy, setOrderBy] = useState("id");
-  const [order, setOrder] = useState("asc");
+  const [order, setOrder] = useState("desc");
   const [ids, setIds] = useState([]);
   const { getManifests, manifests } = useManifestsContext();
   const {