From a5c29a472109b7deb099cd2268b2c259230cb118 Mon Sep 17 00:00:00 2001 From: John Wu <76966357+jwu-fisker@users.noreply.github.com> Date: Thu, 15 Jun 2023 14:39:21 -0700 Subject: [PATCH] CEC-4572 tweak digital twin display and form (#362) * CEC-4572 tweak form * update snapshots * Clean up * Hide DTC tab --- .../App/__snapshots__/App.test.js.snap | 99 +++++------ .../Details/__snapshots__/index.test.jsx.snap | 75 +++++---- src/components/Cars/Status/Details/index.jsx | 73 +++++---- .../__snapshots__/DetailsTab.test.jsx.snap | 75 +++++---- .../Status/__snapshots__/index.test.jsx.snap | 100 +++++------- src/components/Cars/Status/index.jsx | 4 +- .../Update/__snapshots__/index.test.jsx.snap | 154 +++++++++--------- src/components/Cars/Update/index.jsx | 46 +++--- 8 files changed, 300 insertions(+), 326 deletions(-) diff --git a/src/components/App/__snapshots__/App.test.js.snap b/src/components/App/__snapshots__/App.test.js.snap index d5f2921..28e0e1e 100644 --- a/src/components/App/__snapshots__/App.test.js.snap +++ b/src/components/App/__snapshots__/App.test.js.snap @@ -11266,24 +11266,6 @@ exports[`App Route /vehicle-status authenticated 1`] = ` class="MuiTouchRipple-root" /> -

- Log Level + Tags : - info + none

- - CANBus -

- Enabled + Log Level + + : + info +

+

+ + CANBus Enabled : true @@ -11414,7 +11400,7 @@ exports[`App Route /vehicle-status authenticated 1`] = `

- Enabled + Data Logger Enabled : true @@ -11433,15 +11419,12 @@ exports[`App Route /vehicle-status authenticated 1`] = ` : 3

-
-

- DebugMask + DTC Enabled : + false

- Tags + Debug Mask :

@@ -11457,24 +11440,6 @@ exports[`App Route /vehicle-status authenticated 1`] = `
- - -
+
@@ -11593,12 +11580,6 @@ exports[`App Route /vehicle-status authenticated 1`] = ` id="tabpanel-9" role="tabpanel" /> - diff --git a/src/components/Cars/Status/Details/__snapshots__/index.test.jsx.snap b/src/components/Cars/Status/Details/__snapshots__/index.test.jsx.snap index fb68c0c..7cadd4e 100644 --- a/src/components/Cars/Status/Details/__snapshots__/index.test.jsx.snap +++ b/src/components/Cars/Status/Details/__snapshots__/index.test.jsx.snap @@ -89,21 +89,25 @@ exports[`VehicleDetailsTab Render 1`] = `

- Log Level + Tags : - info + none

- - CANBus -

- Enabled + Log Level + + : + info +

+

+ + CANBus Enabled : true @@ -117,7 +121,7 @@ exports[`VehicleDetailsTab Render 1`] = `

- Enabled + Data Logger Enabled : true @@ -136,15 +140,12 @@ exports[`VehicleDetailsTab Render 1`] = ` : 3

-
-

- DebugMask + DTC Enabled : + false

- Tags + Debug Mask :

@@ -160,24 +161,6 @@ exports[`VehicleDetailsTab Render 1`] = `
- - -
+
diff --git a/src/components/Cars/Status/Details/index.jsx b/src/components/Cars/Status/Details/index.jsx index 99b8bf7..cb8a973 100644 --- a/src/components/Cars/Status/Details/index.jsx +++ b/src/components/Cars/Status/Details/index.jsx @@ -1,4 +1,4 @@ -import { Grid, Tooltip, Checkbox, FormControlLabel } from "@material-ui/core"; +import { Checkbox, FormControlLabel, Grid, Tooltip } from "@material-ui/core"; import DeleteIcon from "@material-ui/icons/Delete"; import EditIcon from "@material-ui/icons/Edit"; import UploadIcon from '@mui/icons-material/Upload'; @@ -114,23 +114,26 @@ const MainForm = ({ vin }) => {

Info Source: {vehicle.info_source}

- {vehicle.log_level != null && ( +

+ Tags: {vehicle.tags ? vehicle.tags.join(", ") : "none" } +

+ + + {vehicle.log_level != null && (

Log Level: {vehicle.log_level}

)} -
{vehicle.canbus && ( - - CANBus + <>

- Enabled: {vehicle.canbus.enabled.toString()} + CANBus Enabled: {vehicle.canbus.enabled.toString()}

Max Memory Buffer Size: {vehicle.canbus.max_mem_buffer_size ?? "Default"}

- Enabled: {vehicle.canbus.data_logger_enabled.toString()} + Data Logger Enabled: {vehicle.canbus.data_logger_enabled.toString()}

Max Disk Buffer Size: {vehicle.canbus.max_disk_buffer_size ?? "Default"} @@ -138,19 +141,40 @@ const MainForm = ({ vin }) => {

Filters: {vehicle.canbus.filters ? vehicle.canbus.filters.length : 0}

-
+

+ DTC Enabled: { (vehicle.canbus.dtc_enabled || false).toString() } +

+ )} + {showDebugMask && (

- DebugMask: {vehicle.debug_mask} + Debug Mask: {vehicle.debug_mask}

)} -

- Tags: {vehicle.tags} -

+ + + } + /> + + setShowUploadConfigModal(true)} > + + + +
{ > - + - - - } - /> - - setShowUploadConfigModal(true)}> - - - - - { > setShowDeleteModal(true)}> - + diff --git a/src/components/Cars/Status/__snapshots__/DetailsTab.test.jsx.snap b/src/components/Cars/Status/__snapshots__/DetailsTab.test.jsx.snap index 58bfd4f..fedbdd8 100644 --- a/src/components/Cars/Status/__snapshots__/DetailsTab.test.jsx.snap +++ b/src/components/Cars/Status/__snapshots__/DetailsTab.test.jsx.snap @@ -97,21 +97,25 @@ exports[`DetailsTab Render 1`] = `

- Log Level + Tags : - info + none

- - CANBus -

- Enabled + Log Level + + : + info +

+

+ + CANBus Enabled : true @@ -125,7 +129,7 @@ exports[`DetailsTab Render 1`] = `

- Enabled + Data Logger Enabled : true @@ -144,15 +148,12 @@ exports[`DetailsTab Render 1`] = ` : 3

-
-

- DebugMask + DTC Enabled : + false

- Tags + Debug Mask :

@@ -168,24 +169,6 @@ exports[`DetailsTab Render 1`] = `
- - -
+
diff --git a/src/components/Cars/Status/__snapshots__/index.test.jsx.snap b/src/components/Cars/Status/__snapshots__/index.test.jsx.snap index a4a0c43..7eb546e 100644 --- a/src/components/Cars/Status/__snapshots__/index.test.jsx.snap +++ b/src/components/Cars/Status/__snapshots__/index.test.jsx.snap @@ -213,24 +213,6 @@ exports[`CarStatus Render 1`] = ` class="MuiTouchRipple-root" /> -
:

-
-
-

- - DebugMask - - : -

-
-

Tags : + none +

+
+
+
+

+ + Debug Mask + + :

- - -
+
@@ -484,12 +470,6 @@ exports[`CarStatus Render 1`] = ` id="tabpanel-9" role="tabpanel" /> -
diff --git a/src/components/Cars/Status/index.jsx b/src/components/Cars/Status/index.jsx index b30bb13..9e4a0b7 100644 --- a/src/components/Cars/Status/index.jsx +++ b/src/components/Cars/Status/index.jsx @@ -19,7 +19,6 @@ import ECUsTab from "./ECUsTab"; import FleetsTab from "./FleetsTab"; import RemoteCommandsTab from "./RemoteCommandsTab"; import TRexLogsTab from "./TRexLogsTab"; -import DTCTimeline from "../../DTCTimeline/DTCTimeline"; const tabHashes = ["details", "updates", "filters"]; @@ -74,12 +73,13 @@ const TabViews = [ component: SelfServeTab, rolesPerProvider: Permissions.FiskerRead, }, + /* { label: "DTC Timeline", component: DTCTimeline, rolesPerProvider: Permissions.FiskerMagnaRead, } - + */ ]; const filterTabs = (data, groups, providers) => { diff --git a/src/components/Cars/Update/__snapshots__/index.test.jsx.snap b/src/components/Cars/Update/__snapshots__/index.test.jsx.snap index ee2b41a..8bab667 100644 --- a/src/components/Cars/Update/__snapshots__/index.test.jsx.snap +++ b/src/components/Cars/Update/__snapshots__/index.test.jsx.snap @@ -434,6 +434,43 @@ exports[`VehicleUpdate Render 1`] = `
+
+ +
+ + +
+
-
+
@@ -978,7 +1015,7 @@ exports[`VehicleUpdate Render 1`] = ` for="debug_mask" id="debug_mask-label" > - DebugMask + Debug Mask
- DebugMask - - - -
-
-
- -
- - diff --git a/src/components/Cars/Update/index.jsx b/src/components/Cars/Update/index.jsx index dc7c141..25ab193 100644 --- a/src/components/Cars/Update/index.jsx +++ b/src/components/Cars/Update/index.jsx @@ -337,6 +337,22 @@ const MainForm = () => { fullWidth inputRef={infoSourceEl} /> + Log Level { disabled={!canbusEnabled} /> } label="Data Logger Enabled" /> - - } label="DTC Enabled" /> { required fullWidth /> + + } label="DTC Enabled" /> {showDebugMask && ( { inputRef={debugMaskEl} /> )} -