From aa36b2eb9199eff02379bbc023eadbac9e7bbafb Mon Sep 17 00:00:00 2001
From: John Wu <76966357+jwu-fisker@users.noreply.github.com>
Date: Fri, 26 Aug 2022 16:12:12 -0700
Subject: [PATCH] CEC-2360 Fix filename display and add manifest type (#191)

* CEC-2360 Fix filename display and add manifest type

* const
---
 .../Contexts/__mocks__/ManifestsContext.jsx         |  2 --
 .../Details/__snapshots__/index.test.jsx.snap       |  4 ++--
 src/components/Manifest/Details/index.jsx           | 13 ++++++++++---
 3 files changed, 12 insertions(+), 7 deletions(-)

diff --git a/src/components/Contexts/__mocks__/ManifestsContext.jsx b/src/components/Contexts/__mocks__/ManifestsContext.jsx
index 17a2638..cc0023d 100644
--- a/src/components/Contexts/__mocks__/ManifestsContext.jsx
+++ b/src/components/Contexts/__mocks__/ManifestsContext.jsx
@@ -18,7 +18,6 @@ let manifest = {
       files: [
         {
           file_id: "b0cda514c94080b4",
-          filename: "LARGE.jpg",
           url: "https://upload-dev.fiskerdps.com/92bbc448-99c8-4851-91ad-f8042e4deb49/LARGE.jpg",
           write_region: {
             offset: 100,
@@ -35,7 +34,6 @@ let manifest = {
         },
         {
           file_id: "4B897b1DcbeCds8e9",
-          filename: "SMALL.jpg",
           url: "https://upload-dev.fiskerdps.com/92bbc448-99c8-4851-91ad-f8042e4deb49/SMALL.jpg",
           write_region: {
             offset: 120559274,
diff --git a/src/components/Manifest/Details/__snapshots__/index.test.jsx.snap b/src/components/Manifest/Details/__snapshots__/index.test.jsx.snap
index 1042fa1..9c0fd0d 100644
--- a/src/components/Manifest/Details/__snapshots__/index.test.jsx.snap
+++ b/src/components/Manifest/Details/__snapshots__/index.test.jsx.snap
@@ -107,7 +107,7 @@ Object {
           </div>
           <ul>
             <li>
-              Test Deployment 1.0.100
+              Test Deployment 1.0.100 [standard]
             </li>
             <li>
               Deployment folder test https://releasenotes.com
@@ -162,7 +162,7 @@ Object {
         </div>
         <ul>
           <li>
-            Test Deployment 1.0.100
+            Test Deployment 1.0.100 [standard]
           </li>
           <li>
             Deployment folder test https://releasenotes.com
diff --git a/src/components/Manifest/Details/index.jsx b/src/components/Manifest/Details/index.jsx
index addf6eb..a2b18e8 100644
--- a/src/components/Manifest/Details/index.jsx
+++ b/src/components/Manifest/Details/index.jsx
@@ -11,13 +11,18 @@ const getMemoryRegion = (label, region) => {
   return `, ${label}: [Offset: ${region.offset}, Length: ${region.length}]`;
 };
 
+const getFilename = (url) => {
+  const items = url.split("/");
+  return items[items.length - 1];
+};
+
 const ECUFileList = (files) => {
   if (!files || files.length === 0) return "No files";
   return (
     <ul>
       {files.map((file) => (
-        <li key={file.filename}>
-          <a href={file.url}>{file.filename}</a>
+        <li key={file.file_id}>
+          <a href={file.url}>{getFilename(file.url)}</a>
           {`, File ID: ${file.file_id}, Type: ${file.type}, Download Size: ${
             file.file_size
           }, CRC32: ${file.checksum ?? "00000000"}
@@ -99,7 +104,9 @@ const ManifestDetails = ({ opened }) => {
         Hide Details
       </div>
       <ul>
-        <li>{`${manifest.name} ${manifest.version}`}</li>
+        <li>{`${manifest.name} ${manifest.version} [${
+          manifest.type || "standard"
+        }]`}</li>
         <li>{`${manifest.description} ${manifest.release_notes}`}</li>
         <li>ECUs: {ECUList(manifest.ecu_updates)}</li>
       </ul>