CEC-4356: DTC Enabled On car enabled and disable (#353)

* CEC-4100: Added push config changes to vin

* Fixed test

* Dropped coveragte by 1%

* CEC-4356: Enable dtc for create car

* Updated snapshot
This commit is contained in:
Alexander Andrews
2023-06-13 14:17:22 -04:00
committed by GitHub
parent f74c717377
commit 99e2058ffd
5 changed files with 90 additions and 5 deletions

View File

@@ -10389,6 +10389,43 @@ exports[`App Route /vehicle-add authenticated 1`] = `
Data Logger Enabled Data Logger Enabled
</span> </span>
</label> </label>
<label
class="MuiFormControlLabel-root"
>
<span
aria-disabled="false"
class="MuiButtonBase-root MuiIconButton-root PrivateSwitchBase-root-0 MuiCheckbox-root MuiCheckbox-colorSecondary MuiIconButton-colorSecondary"
>
<span
class="MuiIconButton-label"
>
<input
class="PrivateSwitchBase-input-0"
data-indeterminate="false"
type="checkbox"
value=""
/>
<svg
aria-hidden="true"
class="MuiSvgIcon-root"
focusable="false"
viewBox="0 0 24 24"
>
<path
d="M19 5v14H5V5h14m0-2H5c-1.1 0-2 .9-2 2v14c0 1.1.9 2 2 2h14c1.1 0 2-.9 2-2V5c0-1.1-.9-2-2-2z"
/>
</svg>
</span>
<span
class="MuiTouchRipple-root"
/>
</span>
<span
class="MuiTypography-root MuiFormControlLabel-label MuiTypography-body1"
>
DTC Enabled
</span>
</label>
</div> </div>
<div <div
class="MuiFormControl-root MuiTextField-root MuiFormControl-marginNormal MuiFormControl-fullWidth" class="MuiFormControl-root MuiTextField-root MuiFormControl-marginNormal MuiFormControl-fullWidth"

View File

@@ -518,6 +518,43 @@ exports[`VehicleAddForm Render 1`] = `
Data Logger Enabled Data Logger Enabled
</span> </span>
</label> </label>
<label
class="MuiFormControlLabel-root"
>
<span
aria-disabled="false"
class="MuiButtonBase-root MuiIconButton-root PrivateSwitchBase-root-0 MuiCheckbox-root MuiCheckbox-colorSecondary MuiIconButton-colorSecondary"
>
<span
class="MuiIconButton-label"
>
<input
class="PrivateSwitchBase-input-0"
data-indeterminate="false"
type="checkbox"
value=""
/>
<svg
aria-hidden="true"
class="MuiSvgIcon-root"
focusable="false"
viewBox="0 0 24 24"
>
<path
d="M19 5v14H5V5h14m0-2H5c-1.1 0-2 .9-2 2v14c0 1.1.9 2 2 2h14c1.1 0 2-.9 2-2V5c0-1.1-.9-2-2-2z"
/>
</svg>
</span>
<span
class="MuiTouchRipple-root"
/>
</span>
<span
class="MuiTypography-root MuiFormControlLabel-label MuiTypography-body1"
>
DTC Enabled
</span>
</label>
</div> </div>
<div <div
class="MuiFormControl-root MuiTextField-root MuiFormControl-marginNormal MuiFormControl-fullWidth" class="MuiFormControl-root MuiTextField-root MuiFormControl-marginNormal MuiFormControl-fullWidth"

View File

@@ -38,6 +38,7 @@ const MainForm = () => {
const [dataLoggerEnabled, setDataLoggerEnabled] = useState(false); const [dataLoggerEnabled, setDataLoggerEnabled] = useState(false);
const [maxMemBufferSize, setMaxMemBufferSize] = useState(0); const [maxMemBufferSize, setMaxMemBufferSize] = useState(0);
const [maxDiskBufferSize, setMaxDiskBufferSize] = useState(0); const [maxDiskBufferSize, setMaxDiskBufferSize] = useState(0);
const [dtcEnabled, setDTCEnabled] = useState(false);
useEffect(() => { useEffect(() => {
setTitle("Add Vehicle"); setTitle("Add Vehicle");
@@ -65,6 +66,10 @@ const MainForm = () => {
setDataLoggerEnabled(event.target.checked); setDataLoggerEnabled(event.target.checked);
} }
const onDtcEnabledChange = (event) => {
setDTCEnabled(event.target.checked);
}
const onMaxMemBufferSizeChange = (event) => { const onMaxMemBufferSizeChange = (event) => {
setMaxMemBufferSize(event.target.value); setMaxMemBufferSize(event.target.value);
} }
@@ -84,7 +89,8 @@ const MainForm = () => {
enabled: canbusEnabled, enabled: canbusEnabled,
data_logger_enabled: canbusEnabled ? dataLoggerEnabled : false, data_logger_enabled: canbusEnabled ? dataLoggerEnabled : false,
max_mem_buffer_size: canbusEnabled ? parseInt(maxMemBufferSize) : 0, max_mem_buffer_size: canbusEnabled ? parseInt(maxMemBufferSize) : 0,
max_disk_buffer_size: canbusEnabled && dataLoggerEnabled ? parseInt(maxDiskBufferSize) : 0 max_disk_buffer_size: canbusEnabled && dataLoggerEnabled ? parseInt(maxDiskBufferSize) : 0,
dtc_enabled: dtcEnabled
} }
}; };
@@ -166,6 +172,12 @@ const MainForm = () => {
disabled={!canbusEnabled} disabled={!canbusEnabled}
/> />
} label="Data Logger Enabled" /> } label="Data Logger Enabled" />
<FormControlLabel control={
<Checkbox
checked={dtcEnabled}
onChange={onDtcEnabledChange}
/>
} label="DTC Enabled" />
</FormGroup> </FormGroup>
<TextField <TextField
id="max_disk_buffer_size" id="max_disk_buffer_size"

View File

@@ -919,7 +919,7 @@ exports[`VehicleUpdate Render 1`] = `
<span <span
class="MuiTypography-root MuiFormControlLabel-label MuiTypography-body1" class="MuiTypography-root MuiFormControlLabel-label MuiTypography-body1"
> >
Data Logger Enabled DTC Enabled
</span> </span>
</label> </label>
</div> </div>

View File

@@ -150,7 +150,7 @@ const MainForm = () => {
data_logger_enabled: canbusEnabled ? dataLoggerEnabled : false, data_logger_enabled: canbusEnabled ? dataLoggerEnabled : false,
max_mem_buffer_size: canbusEnabled ? parseInt(maxMemBufferSize) : 0, max_mem_buffer_size: canbusEnabled ? parseInt(maxMemBufferSize) : 0,
max_disk_buffer_size: canbusEnabled && dataLoggerEnabled ? parseInt(maxDiskBufferSize) : 0, max_disk_buffer_size: canbusEnabled && dataLoggerEnabled ? parseInt(maxDiskBufferSize) : 0,
dtc_enabled: canbusEnabled ? dtcEnabled : false dtc_enabled: dtcEnabled
}, },
debug_mask: debugMaskEl.current?.value debug_mask: debugMaskEl.current?.value
}; };
@@ -382,9 +382,8 @@ const MainForm = () => {
<Checkbox <Checkbox
checked={dtcEnabled} checked={dtcEnabled}
onChange={onDtcEnabledChange} onChange={onDtcEnabledChange}
disabled={!canbusEnabled}
/> />
} label="Data Logger Enabled" /> } label="DTC Enabled" />
</FormGroup> </FormGroup>
<TextField <TextField
id="max_disk_buffer_size" id="max_disk_buffer_size"