use last CAN signal as timestamp for pagination

This commit is contained in:
Tristan Timblin
2023-11-07 21:01:02 -08:00
parent 0851434e13
commit 87cb44652d
4 changed files with 65 additions and 34 deletions

View File

@@ -5,6 +5,11 @@ import {
TableCell, TableCell,
TableHead, TableHead,
TableRow, TableRow,
Box,
FormControl,
InputLabel,
Select,
MenuItem,
} from "@material-ui/core"; } from "@material-ui/core";
import { import {
@@ -13,7 +18,7 @@ import {
} from "../../Contexts/CANSignalsContext"; } from "../../Contexts/CANSignalsContext";
const Main = ({ vin }) => { const Main = ({ vin }) => {
const { signals, setVIN, duration } = useCANSignalContext(); const { signals, setVIN, queryDate, delays, delayIndex, setDelayIndex } = useCANSignalContext();
useEffect(() => { useEffect(() => {
setVIN(vin); setVIN(vin);
@@ -27,7 +32,11 @@ const Main = ({ vin }) => {
return ( return (
<> <>
(Received within the last {duration} seconds) <Box sx={{ display: "flex", alignItems: "baseline", gap: "8px" }}>
<span>Searching every</span>
<DelayController delays={delays} delayIndex={delayIndex} setDelayIndex={setDelayIndex} />
<span>seconds for signals sent after {queryDate}.</span>
</Box>
<Table> <Table>
<TableHead> <TableHead>
<TableRow> <TableRow>
@@ -56,4 +65,33 @@ const CANSignals = (props) => (
</CANSignalProvider> </CANSignalProvider>
); );
const DelayController = ({
delays,
delayIndex,
setDelayIndex
}) => {
const label = "Delay";
const handleChange = (event) => {
setDelayIndex(event.target.value);
}
return (
<FormControl variant="standard" sx={{ m: 1, minWidth: 120 }}>
<InputLabel id="can-signal-delay">{label}</InputLabel>
<Select
labelId="can-signal-delay"
onChange={handleChange}
value={delayIndex}
label={label}
>
{delays.map((delay, i) => {
return (
<MenuItem value={i} selected={i === delayIndex} key={delay}>{delay / 1000}</MenuItem>
);
})}
</Select>
</FormControl>
)
}
export default CANSignals; export default CANSignals;

View File

@@ -27,48 +27,42 @@ const transformSignals = (signals) =>
export const CANSignalProvider = ({ token, children }) => { export const CANSignalProvider = ({ token, children }) => {
// auto scale polling if not getting response // auto scale polling if not getting response
const durations = [10000, 30000, 60000, 120000];
const delays = [500, 1500, 3000, 6000]; const delays = [500, 1500, 3000, 6000];
const [delayIndex, setDelayIndex] = useState(2);
const [vin, setVIN] = useState(null); const [vin, setVIN] = useState(null);
const [signals, setSignals] = useState([]); const [signals, setSignals] = useState([]);
const [delayIndex, setDelayIndex] = useState(0); const [utc, setUtc] = useState(undefined);
useInterval( useInterval(
() => { () => {
getCANSignals() getCANSignals()
}, vin ? delays[delayIndex] : null }, vin ? delays[delayIndex] : null
) );
const getCANSignals = async () => { const getCANSignals = async () => {
try { try {
if (!vin) return; if (!vin) return;
const date = new Date();
date.setUTCSeconds(date.getUTCSeconds() - durations[delayIndex]);
const result = await api.getCANSignals(vin, { const result = await api.getCANSignals(vin, {
after_utc: date, after_utc: utc,
}, token); }, token);
if (result.error)
if (result.error) {
throw new Error(`Get CAN signals error. ${result.message}`); throw new Error(`Get CAN signals error. ${result.message}`);
}
const mostRecentTimestamp = result.data?.[0]?.timestamp;
if (mostRecentTimestamp) {
setUtc(new Date(mostRecentTimestamp).getTime() - 50); // apply slight offset to ensure last CAN Signals sent before sleep are returned.
} else {
setUtc(new Date().getTime());
}
const items = transformSignals(result.data); const items = transformSignals(result.data);
if (items.length > 0) { if (items.length > 0) {
setDelayIndex((index) => {
if (index === 0) {
return 0;
}
return index -= 1;
});
setSignals(items); setSignals(items);
} else { } else {
setDelayIndex((index) => {
if (index < delays.length - 1) {
return index += 1;
}
return index;
});
setSignals([BlankSignal("No signals")]); setSignals([BlankSignal("No signals")]);
} }
} catch (e) { } catch (e) {
@@ -79,9 +73,12 @@ export const CANSignalProvider = ({ token, children }) => {
return ( return (
<CANSignalContext.Provider <CANSignalContext.Provider
value={{ value={{
duration: durations[delayIndex] / 1000, queryDate: new Date(utc).toLocaleTimeString(),
signals, signals,
setVIN, setVIN,
delays,
delayIndex,
setDelayIndex,
}} }}
> >
{children} {children}

View File

@@ -8,7 +8,7 @@ import {
waitFor, waitFor,
act, act,
} from "@testing-library/react"; } from "@testing-library/react";
import {CANSignalProvider, useCANSignalContext} from "./CANSignalsContext"; import { CANSignalProvider, useCANSignalContext } from "./CANSignalsContext";
const checkSignalsResults = (filters) => { const checkSignalsResults = (filters) => {
expect(screen.getByTestId("signals").innerHTML).toEqual(filters); expect(screen.getByTestId("signals").innerHTML).toEqual(filters);
@@ -19,14 +19,15 @@ describe("CANSignalsContext", () => {
beforeEach(() => { beforeEach(() => {
jest.useFakeTimers("setInterval"); jest.useFakeTimers("setInterval");
const TestComp = () => { const TestComp = () => {
const { signals, setVIN } = useCANSignalContext(); const { signals, setVIN, setDelayIndex } = useCANSignalContext();
setDelayIndex(0);
return ( return (
<> <>
<div data-testid="signals">{JSON.stringify(signals)}</div> <div data-testid="signals">{JSON.stringify(signals)}</div>
<button <button
data-testid="getSignals" data-testid="getSignals"
onClick={()=>{setVIN("TESTVIN1234567890")}} onClick={() => { setVIN("TESTVIN1234567890") }}
/> />
</> </>
); );
@@ -54,12 +55,12 @@ describe("CANSignalsContext", () => {
await waitFor(() => await waitFor(() =>
expect(screen.getByTestId("signals").innerHTML).toBe("[]") expect(screen.getByTestId("signals").innerHTML).toBe("[]")
); );
jest.advanceTimersByTime(501); jest.advanceTimersByTime(3001);
}) })
await waitFor(() => { await waitFor(() => {
return expect(screen.getByTestId("signals").innerHTML).not.toBe("[]"); return expect(screen.getByTestId("signals").innerHTML).not.toBe("[]");
} ); });
checkSignalsResults(JSON.stringify(expectedSignalsData)); checkSignalsResults(JSON.stringify(expectedSignalsData));
}); });

View File

@@ -217,18 +217,13 @@ const vehiclesAPI = {
* *
* @param {String} vin The VIN of the car * @param {String} vin The VIN of the car
* @param {Object} filter * @param {Object} filter
* @param {Date} filter.after_utc Point in time to begin signal response * @param {Integer} filter.after_utc Point in time to begin signal response
* @param {Integer} filter.limit Max number of CAN Signals to return * @param {Integer} filter.limit Max number of CAN Signals to return
* @param {String} token * @param {String} token
* @returns {Array} * @returns {Array}
*/ */
getCANSignals: async (vin, filter = {}, token) => { getCANSignals: async (vin, filter = {}, token) => {
if (filter.after_utc instanceof Date && !isNaN(filter.after_utc)) {
filter.after_utc = filter.after_utc.getTime();
}
const url = addQueryParams(`${API_ENDPOINT}/cansignals/${vin}`, filter); const url = addQueryParams(`${API_ENDPOINT}/cansignals/${vin}`, filter);
console.log(url)
return fetch(url, { return fetch(url, {
method: "GET", method: "GET",
headers: Object.assign( headers: Object.assign(