CEC-3751, CEC-3478 misc window status and invalid location value (#287)

* CEC-3751 misc window status
CEC-3478 invalid location value

* Fix snapshot
Update browser list
This commit is contained in:
John Wu
2023-03-02 12:26:41 -08:00
committed by GitHub
parent 54f4386a58
commit 7b6a2bfa11
4 changed files with 21 additions and 24 deletions

View File

@@ -123,7 +123,7 @@ exports[`DigitalTwinTab Render 1`] = `
sunroof
</b>
:
closed
closed (0)
</p>
</div>
<div

View File

@@ -13,6 +13,14 @@ const openCloseState = (value) => (value ? "open" : "closed");
const mapOpenCloseState = (value) =>
keyValueTemplate(value[0], openCloseState(value[1]));
const windowState = (value) => {
if (value[1] === 0 || value[1] > 100) {
return keyValueTemplate(value[0], `closed (${value[1]})`);
} else {
return keyValueTemplate(value[0], `${value[1]}% open`);
}
}
const DigitalTwin = (props) => {
const classes = useStyles();
const { battery, doors, location, trex_version, ip, updated, windows, misc_windows, sunroof, dbc_version, door_locks } = props;
@@ -45,12 +53,7 @@ const DigitalTwin = (props) => {
<div className={classes.popupSection}>
<h3>Windows</h3>
{Object.entries(windows).map((value) => {
if (value[1] === 0) {
return keyValueTemplate(value[0], "closed");
} else {
const percentOpen = Math.min(value[1], 100);
return keyValueTemplate(value[0], `${percentOpen}% open`);
}
return windowState(value);
})}
</div>
)}
@@ -58,11 +61,7 @@ const DigitalTwin = (props) => {
<div className={classes.popupSection}>
<h3>Misc Windows</h3>
{Object.entries(misc_windows).map((value) => {
if (value[1] === 0 || value[1] > 100) {
return keyValueTemplate(value[0], `closed ${value[1]}%`);
} else {
return keyValueTemplate(value[0], `${value[1]}% open`);
}
return windowState(value);
})}
</div>
)}
@@ -70,12 +69,7 @@ const DigitalTwin = (props) => {
<div className={classes.popupSection}>
<h3>Sunroof</h3>
{Object.entries(sunroof).map((value) => {
if (value[1] === 0) {
return keyValueTemplate(value[0], "closed");
} else {
const percentOpen = Math.min(value[1], 100);
return keyValueTemplate(value[0], `${percentOpen}% open`);
}
return windowState(value);
})}
</div>
)}

View File

@@ -1,3 +1,5 @@
const invalidLocation = 99999;
export const ValidateLocationData = (location) => {
if (Math.abs(location.latitude) > 90 || Math.abs(location.longitude) > 180) {
return false;
@@ -9,6 +11,7 @@ export const ValidateLocationData = (location) => {
}
export const ValidateLocationByParam = (parameter, value) => {
if (invalidLocation === value) return false;
switch (parameter) {
case "latitude":
return Math.abs(value) <= 90;