fixes from review

This commit is contained in:
padamsen_fisker
2024-01-31 10:46:32 -05:00
parent 0a886904d6
commit 78108e3d9c
6 changed files with 45 additions and 29 deletions

View File

@@ -77,8 +77,9 @@ export const CarUpdatesProvider = ({ children }) => {
try {
setBusy(true);
result = await api.cancelCarUpdate(id, token);
if (result.error)
if (result.error) {
throw new Error(`Cancel car update error. ${result.message}`);
}
} finally {
setBusy(false);
}
@@ -92,8 +93,9 @@ export const CarUpdatesProvider = ({ children }) => {
try {
setBusy(true);
result = await api.deployCarUpdate(id, token);
if (result.error)
if (result.error) {
throw new Error(`Retry car update error. ${result.message}`);
}
} finally {
setBusy(false);
}
@@ -108,8 +110,9 @@ export const CarUpdatesProvider = ({ children }) => {
setBusy(true);
validateDeployCarUpdates(data);
result = await api.createCarUpdates(data, token);
if (result.error)
if (result.error) {
throw new Error(`Deploy car updates error. ${result.message}`);
}
} finally {
setBusy(false);
}
@@ -124,8 +127,9 @@ export const CarUpdatesProvider = ({ children }) => {
setBusy(true);
validateDeployFleetUpdates(data);
result = await api.createFleetUpdates(data, token);
if (result.error)
if (result.error) {
throw new Error(`Deploy fleet updates error. ${result.message}`);
}
} finally {
setBusy(false);
}
@@ -163,8 +167,9 @@ export const CarUpdatesProvider = ({ children }) => {
try {
setBusy(true);
result = await api.getVINUpdates(vin, token);
if (result.error)
if (result.error) {
throw new Error(`Get VIN updates error. ${result.message}`);
}
} finally {
setBusy(false);
}
@@ -230,8 +235,9 @@ export const CarUpdatesProvider = ({ children }) => {
carupdateids.join(","),
token
);
if (result.error)
if (result.error) {
throw new Error(`Get update progress error. ${result.message}`);
}
applyProgressStatuses(result.statuses);
} catch (e) {
@@ -272,8 +278,9 @@ export const CarUpdatesProvider = ({ children }) => {
try {
setBusy(true);
result = await api.getCarUpdateLog(query, token);
if (result.error)
if (result.error) {
throw new Error(`Get car update log error. ${result.message}`);
}
} finally {
setBusy(false);
}
@@ -288,8 +295,9 @@ export const CarUpdatesProvider = ({ children }) => {
setBusy(true);
result = await api.getSUMSVersions(null, token);
if (result.error)
if (result.error) {
throw new Error(`Get software versions error. ${result.message}`);
}
result.data.unshift(SELECT_VERSION_OBJ)
setVersions(result.data);
@@ -307,8 +315,9 @@ export const CarUpdatesProvider = ({ children }) => {
setBusy(true);
result = await api.getSUMSVersions(options, token);
if (result.error)
if (result.error) {
throw new Error(`Get software versions error. ${result.message}`);
}
setVersions(result.data);
if (options && options.offset === 0 && result.total) {
@@ -339,8 +348,9 @@ export const CarUpdatesProvider = ({ children }) => {
}
result = await api.addSUMSVersion(data, token);
if (result.error)
if (result.error) {
throw new Error(`Add SUMS version error. ${result.message}`);
}
} finally {
setBusy(false);
}
@@ -355,8 +365,9 @@ export const CarUpdatesProvider = ({ children }) => {
setBusy(true);
result = await api.deleteSUMSVersion(version, token);
if (result.error)
if (result.error) {
throw new Error(`Delete software version error. ${result.message}`);
}
} finally {
setBusy(false);
}
@@ -373,8 +384,9 @@ export const CarUpdatesProvider = ({ children }) => {
if (!validateSoftwareVersion(version)) throw new Error(`invalid version ${version}`);
result = await api.updateSUMSVersion(id, version, token);
if (result.error)
if (result.error) {
throw new Error(`Update manifest version error. ${result.message}`);
}
} finally {
setBusy(false);
}
@@ -410,8 +422,9 @@ export const CarUpdatesProvider = ({ children }) => {
setBusy(true);
result = await api.deleteSUMSVersionRxSwins(sums_version, rxswin, token);
if (result.error)
if (result.error) {
throw new Error(`Delete software version rxswin error. ${result.message}`);
}
} finally {
setBusy(false);
}
@@ -423,8 +436,9 @@ export const CarUpdatesProvider = ({ children }) => {
try {
setBusy(true);
const result = await api.addSUMSVersionRxSwins(sums_version, data, token);
if (result.error)
if (result.error) {
throw new Error(`Add software version rxswin error. ${result.message}`);
}
return result;
} finally {
setBusy(false);

View File

@@ -156,6 +156,8 @@ export const useCarUpdatesContext = () => ({
stopMonitor: jest.fn(),
approveUpdate: jest.fn(),
getSUMSVersions: jest.fn(() => sumsVersions),
addSUMSVersion: jest.fn(),
deleteSUMSVersion: jest.fn(),
getSUMSVersionRxSwins: jest.fn(() => sumsVersionRxSwins),
deleteSUMSVersionRxSwins: jest.fn(),
addSUMSVersionRxSwins: jest.fn(),