From 25d2b3327ec6a4fd97c79315239b9ff48af09a8d Mon Sep 17 00:00:00 2001
From: John Wu <76966357+jwu-fisker@users.noreply.github.com>
Date: Wed, 5 Oct 2022 10:23:08 -0700
Subject: [PATCH] CEC-2585 Do not make request if there are no VINs (#215)

* CEC-2585 Do not make request if there are no VINs

* Commet
---
 src/components/VehicleMap/index.jsx | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

diff --git a/src/components/VehicleMap/index.jsx b/src/components/VehicleMap/index.jsx
index 253c813..c685dac 100644
--- a/src/components/VehicleMap/index.jsx
+++ b/src/components/VehicleMap/index.jsx
@@ -74,14 +74,16 @@ const Component = () => {
 
   useEffect(() => {
     if (!token) return;
-    if (markers.length > 0) {
-      const vins = markers
-        .filter((marker) => marker[2].length > 0)
-        .map((marker) => marker[2]);
-      getConnections(vins, token).then((conns) => {
-        setConnections(conns);
-      });
-    }
+
+    const vins = markers
+      .filter((marker) => marker[2].length > 0)
+      .map((marker) => marker[2]);
+
+    if (vins.length === 0) return;
+
+    getConnections(vins, token).then((conns) => {
+      setConnections(conns);
+    });
     // eslint-disable-next-line
   }, [markers, token]);