From 220716051bd28d4fdc810d07c32c3ef82ec1eedd Mon Sep 17 00:00:00 2001
From: venkats09 <97122017+venkats09@users.noreply.github.com>
Date: Tue, 15 Mar 2022 09:36:01 -0700
Subject: [PATCH] CEC-1167 ota admin portal (#127)

* Add test coverage script

* Remove unnecessary check

* CEC-1167 unit test and code coverage

* included sonar job

* updated the workflow

* updated sonar properties

* updated sonar properties

* updated sonar properties

* updated sonar properties

* updated sonar properties

* updated sonar properties

* updated sonar properties

* updated sonar properties

Co-authored-by: jwu-fisker <jwu@fiskerinc.com>
---
 .github/workflows/test.yml | 14 ++++++++++++--
 package.json               | 14 ++++++++++++--
 sonar-project.properties   |  6 ++++++
 src/utils/jwt.test.js      |  5 +----
 4 files changed, 31 insertions(+), 8 deletions(-)
 create mode 100644 sonar-project.properties

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index 6495b31..b4f8231 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -1,6 +1,7 @@
 name: Node.js CI
 
-on: [pull_request]
+on: push
+# [pull_request]
 
 jobs:
   build:
@@ -8,6 +9,9 @@ jobs:
 
     steps:
       - uses: actions/checkout@v2
+        with:
+          fetch-depth: 0
+
       - name: Use Node.js ${{ matrix.node-version }}
         uses: actions/setup-node@v2
         with:
@@ -15,6 +19,12 @@ jobs:
           cache: "npm"
       - run: npm install
       - run: npm run build --if-present
-      - run: npm test
+      - run: npm test -- --coverage --coverageDirectory='coverage' --watchAll=false
         env:
           CI: true
+
+      - name: SonarCloud Scan
+        uses: sonarsource/sonarcloud-github-action@master
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
diff --git a/package.json b/package.json
index 4580000..fb0e940 100644
--- a/package.json
+++ b/package.json
@@ -33,6 +33,7 @@
     "build:local": "env-cmd -f .env.local react-scripts build",
     "test": "env-cmd -f .env.local react-scripts test",
     "test:debug": "react-scripts --inspect-brk test --runInBand --no-cache",
+    "test:coverage": "npm test -- --coverage --watchAll=false --no-cache",
     "eject": "react-scripts eject"
   },
   "eslintConfig": {
@@ -53,6 +54,15 @@
     "react-test-renderer": "^17.0.2"
   },
   "jest": {
-    "globalSetup": "./testEnv.js"
+    "globalSetup": "./testEnv.js",
+    "collectCoverageFrom": [
+      "src/**/*.{js,jsx,ts,tsx}"
+    ],
+    "coverageReporters": [
+      "html",
+      "json",
+      "lcov",
+      "cobertura"
+    ]
   }
-}
+}
\ No newline at end of file
diff --git a/sonar-project.properties b/sonar-project.properties
new file mode 100644
index 0000000..42250a5
--- /dev/null
+++ b/sonar-project.properties
@@ -0,0 +1,6 @@
+sonar.projectKey=Fisker-Inc_ota-admin-portal
+sonar.organization=fisker-inc
+sonar.sourceEncoding=UTF-8
+sonar.javascript.coveragePlugin=lcov
+sonar.javascript.lcov.reportPaths=coverage/lcov.info
+sonar.sources=src
\ No newline at end of file
diff --git a/src/utils/jwt.test.js b/src/utils/jwt.test.js
index d5ce7d7..cb292f4 100644
--- a/src/utils/jwt.test.js
+++ b/src/utils/jwt.test.js
@@ -3,11 +3,8 @@ import { TEST_TOKEN } from "./testing";
 
 describe("JWT Helper", () => {
   it("Should decode", () => {
-    const start = Date.now()
     const v = parsePayload(TEST_TOKEN);
-    const diff = Date.now() - start;
-    
-    expect(diff < 2).toBeTruthy();
+
     expect(typeof v).toEqual("object");
     expect(v.exp).toBeTruthy();
   });