From e57d991ea863031d72e930b63bafd7fc3014a3f5 Mon Sep 17 00:00:00 2001
From: Tristan Timblin <ttimblin@fiskerinc.com>
Date: Wed, 31 Jan 2024 10:13:19 -0800
Subject: [PATCH] CEC-5694: display multiple hw_versions (#500)

---
 .../Details/__snapshots__/index.test.jsx.snap |  4 +-
 src/components/Manifest/Details/index.jsx     | 42 +++++++++++--------
 2 files changed, 26 insertions(+), 20 deletions(-)

diff --git a/src/components/Manifest/Details/__snapshots__/index.test.jsx.snap b/src/components/Manifest/Details/__snapshots__/index.test.jsx.snap
index 9c0fd0d..fd848cb 100644
--- a/src/components/Manifest/Details/__snapshots__/index.test.jsx.snap
+++ b/src/components/Manifest/Details/__snapshots__/index.test.jsx.snap
@@ -116,7 +116,7 @@ Object {
               ECUs: 
               <ul>
                 <li>
-                  ICC, SW Version: 1000, HW Version: none, Mode: D
+                  ICC, SW Version: 1000, HW Version: None, Mode: D
                   <br />
                   <ul>
                     <li>
@@ -171,7 +171,7 @@ Object {
             ECUs: 
             <ul>
               <li>
-                ICC, SW Version: 1000, HW Version: none, Mode: D
+                ICC, SW Version: 1000, HW Version: None, Mode: D
                 <br />
                 <ul>
                   <li>
diff --git a/src/components/Manifest/Details/index.jsx b/src/components/Manifest/Details/index.jsx
index a2b18e8..25ca0f6 100644
--- a/src/components/Manifest/Details/index.jsx
+++ b/src/components/Manifest/Details/index.jsx
@@ -23,9 +23,8 @@ const ECUFileList = (files) => {
       {files.map((file) => (
         <li key={file.file_id}>
           <a href={file.url}>{getFilename(file.url)}</a>
-          {`, File ID: ${file.file_id}, Type: ${file.type}, Download Size: ${
-            file.file_size
-          }, CRC32: ${file.checksum ?? "00000000"}
+          {`, File ID: ${file.file_id}, Type: ${file.type}, Download Size: ${file.file_size
+            }, CRC32: ${file.checksum ?? "00000000"}
           ${getMemoryRegion("Write", file.write_region)}
           ${getMemoryRegion("Erase", file.erase_region)}`}
         </li>
@@ -35,20 +34,28 @@ const ECUFileList = (files) => {
 };
 
 const ECUList = (ecus) => {
-  if (!ecus || ecus.length === 0) return "None";
+  const none = "None";
+  if (!ecus || ecus.length === 0) return none;
+
   return (
     <ul>
-      {ecus.map((ecu) => (
-        <li key={ecu.name}>
-          {`${ecu.name}, SW Version: ${ecu.version ?? "None"}, HW Version: ${
-            ecu.hw_version ?? "none"
-          }, Mode: ${ecu.mode ?? "D"}${
-            ecu.self_download ? ", Self Download" : ""
-          }`}
-          <br />
-          {ECUFileList(ecu.files)}
-        </li>
-      ))}
+      {ecus.map((ecu) => {
+        const name = ecu.name;
+        const version = ecu.version ?? none;
+        const hardwareVersions = ecu.hw_versions?.join(", ") ?? ecu.hw_version ?? none;
+        let mode = ecu.mode ?? "D";
+        if (ecu.self_download) {
+          mode += ", Self Download"
+        }
+
+        return (
+          <li key={ecu.name}>
+            {`${name}, SW Version: ${version}, HW Version: ${hardwareVersions}, Mode: ${mode}`}
+            <br />
+            {ECUFileList(ecu.files)}
+          </li>
+        )
+      })}
     </ul>
   );
 };
@@ -104,9 +111,8 @@ const ManifestDetails = ({ opened }) => {
         Hide Details
       </div>
       <ul>
-        <li>{`${manifest.name} ${manifest.version} [${
-          manifest.type || "standard"
-        }]`}</li>
+        <li>{`${manifest.name} ${manifest.version} [${manifest.type || "standard"
+          }]`}</li>
         <li>{`${manifest.description} ${manifest.release_notes}`}</li>
         <li>ECUs: {ECUList(manifest.ecu_updates)}</li>
       </ul>