CEC-4654 limit access to 'Remote Diagnostic Tab' (#380)

* CEC-4654 limit access to 'Remote Diagnostic Tab' Only members of 'Cognito Car Reset' have access. * snapshots * Update src/utils/roles.js
2023-06-30 15:08:59 -07:00
parent 42f22abb0d
commit 02552f261d
11 changed files with 22 additions and 60 deletions
--- a/.env.cec-euprd
+++ b/.env.cec-euprd
@@ -15,6 +15,7 @@ REACT_APP_ROLE_GENERATE_CERTIFICATE=9af2d8c0-c26d-4d6d-bbd1-ac53cbd37ebc
 REACT_APP_ROLE_MANUFACTURE=3412e11a-a2d1-4355-be3e-ef9aa5065b69
 REACT_APP_ROLE_SUPPLIER_APPROVER=a6c9805e-80b2-42b2-bfbb-9df52e5504d8
 REACT_APP_ROLE_MANIFEST_MIGRATION=42798c8a-9fa7-4fb4-82c0-9582cabe364f
+REACT_APP_ROLE_CAR_DIAGNOSTIC=2914e67f-fb85-4b78-b79d-656f4f37faa1
 REACT_APP_ROLE_UPDATE_DEPLOY=e4af2c4c-6c5e-4784-9097-7c18e776d7b6
 REACT_APP_ECCKEY_ENV=
 REACT_APP_HOME_MAP_DEFAULT_LOCATION={"lat":49.8327,"lng":9.8816,"zoom":4.5}
--- a/.env.cec-prd
+++ b/.env.cec-prd
@@ -15,6 +15,7 @@ REACT_APP_ROLE_GENERATE_CERTIFICATE=9af2d8c0-c26d-4d6d-bbd1-ac53cbd37ebc
 REACT_APP_ROLE_MANUFACTURE=3412e11a-a2d1-4355-be3e-ef9aa5065b69
 REACT_APP_ROLE_SUPPLIER_APPROVER=a6c9805e-80b2-42b2-bfbb-9df52e5504d8
 REACT_APP_ROLE_MANIFEST_MIGRATION=42798c8a-9fa7-4fb4-82c0-9582cabe364f
+REACT_APP_ROLE_CAR_DIAGNOSTIC=2914e67f-fb85-4b78-b79d-656f4f37faa1
 REACT_APP_ROLE_UPDATE_DEPLOY=e4af2c4c-6c5e-4784-9097-7c18e776d7b6
 REACT_APP_ECCKEY_ENV=
 REACT_APP_HOME_MAP_DEFAULT_LOCATION={"lat":37.0902,"lng":-95.7129,"zoom":4.5}
--- a/.env.dev
+++ b/.env.dev
@@ -15,6 +15,7 @@ REACT_APP_ROLE_GENERATE_CERTIFICATE=746f34b0-9ba0-4b5d-8d84-0256a9c8e390
 REACT_APP_ROLE_MANUFACTURE=3412e11a-a2d1-4355-be3e-ef9aa5065b69
 REACT_APP_ROLE_SUPPLIER_APPROVER=a6c9805e-80b2-42b2-bfbb-9df52e5504d8
 REACT_APP_ROLE_MANIFEST_MIGRATION=42798c8a-9fa7-4fb4-82c0-9582cabe364f
+REACT_APP_ROLE_CAR_DIAGNOSTIC=2914e67f-fb85-4b78-b79d-656f4f37faa1
 REACT_APP_ROLE_UPDATE_DEPLOY=3590ec3f-1c05-428b-81a4-40b00baf83de
 REACT_APP_ECCKEY_ENV=stage,prod
 REACT_APP_HOME_MAP_DEFAULT_LOCATION={"lat":37.0902,"lng":-95.7129,"zoom":4.5}
--- a/.env.local
+++ b/.env.local
@@ -16,6 +16,7 @@ REACT_APP_ROLE_MANUFACTURE=3412e11a-a2d1-4355-be3e-ef9aa5065b69
 REACT_APP_ROLE_SUPPLIER_APPROVER=a6c9805e-80b2-42b2-bfbb-9df52e5504d8
 REACT_APP_ROLE_MANIFEST_MIGRATION=42798c8a-9fa7-4fb4-82c0-9582cabe364f
 REACT_APP_ROLE_UPDATE_DEPLOY=3590ec3f-1c05-428b-81a4-40b00baf83de
+REACT_APP_ROLE_CAR_DIAGNOSTIC=2914e67f-fb85-4b78-b79d-656f4f37faa1
 REACT_APP_ECCKEY_ENV=dev,stage,prod
 REACT_APP_HOME_MAP_DEFAULT_LOCATION={"lat":37.0902,"lng":-95.7129,"zoom":4.5}
 REACT_APP_ENABLE_DEBUGMASK=1
--- a/.env.prd
+++ b/.env.prd
@@ -15,6 +15,7 @@ REACT_APP_ROLE_GENERATE_CERTIFICATE=746f34b0-9ba0-4b5d-8d84-0256a9c8e390
 REACT_APP_ROLE_MANUFACTURE=3412e11a-a2d1-4355-be3e-ef9aa5065b69
 REACT_APP_ROLE_SUPPLIER_APPROVER=a6c9805e-80b2-42b2-bfbb-9df52e5504d8
 REACT_APP_ROLE_MANIFEST_MIGRATION=42798c8a-9fa7-4fb4-82c0-9582cabe364f
+REACT_APP_ROLE_CAR_DIAGNOSTIC=2914e67f-fb85-4b78-b79d-656f4f37faa1
 REACT_APP_ROLE_UPDATE_DEPLOY=e4af2c4c-6c5e-4784-9097-7c18e776d7b6
 REACT_APP_ECCKEY_ENV=stage
 REACT_APP_HOME_MAP_DEFAULT_LOCATION={"lat":37.0902,"lng":-95.7129,"zoom":4.5}
--- a/.env.stg
+++ b/.env.stg
@@ -15,6 +15,7 @@ REACT_APP_ROLE_GENERATE_CERTIFICATE=746f34b0-9ba0-4b5d-8d84-0256a9c8e390
 REACT_APP_ROLE_MANUFACTURE=3412e11a-a2d1-4355-be3e-ef9aa5065b69
 REACT_APP_ROLE_SUPPLIER_APPROVER=a6c9805e-80b2-42b2-bfbb-9df52e5504d8
 REACT_APP_ROLE_MANIFEST_MIGRATION=42798c8a-9fa7-4fb4-82c0-9582cabe364f
+REACT_APP_ROLE_CAR_DIAGNOSTIC=2914e67f-fb85-4b78-b79d-656f4f37faa1
 REACT_APP_ROLE_UPDATE_DEPLOY=3590ec3f-1c05-428b-81a4-40b00baf83de
 REACT_APP_ECCKEY_ENV=prod
 REACT_APP_HOME_MAP_DEFAULT_LOCATION={"lat":37.0902,"lng":-95.7129,"zoom":4.5}
--- a/.env.template
+++ b/.env.template
@@ -15,6 +15,7 @@ REACT_APP_ROLE_GENERATE_CERTIFICATE=746f34b0-9ba0-4b5d-8d84-0256a9c8e390
 REACT_APP_ROLE_MANUFACTURE=3412e11a-a2d1-4355-be3e-ef9aa5065b69
 REACT_APP_ROLE_SUPPLIER_APPROVER=a6c9805e-80b2-42b2-bfbb-9df52e5504d8
 REACT_APP_ROLE_MANIFEST_MIGRATION=42798c8a-9fa7-4fb4-82c0-9582cabe364f
+REACT_APP_ROLE_CAR_DIAGNOSTIC=2914e67f-fb85-4b78-b79d-656f4f37faa1
 REACT_APP_ROLE_UPDATE_DEPLOY=3590ec3f-1c05-428b-81a4-40b00baf83de
 REACT_APP_ECCKEY_ENV=dev,stage,prod
 REACT_APP_HOME_MAP_DEFAULT_LOCATION={"lat":37.0902,"lng":-95.7129,"zoom":4.5}
--- a/src/components/App/snapshots/App.test.js.snap
+++ b/src/components/App/snapshots/App.test.js.snap
@@ -11365,7 +11365,7 @@ exports[`App Route /vehicle-status authenticated 1`] = `
                      <span
                        class="MuiTab-wrapper"
                      >
-                        Remote Diagnostic Commands
+                        Fleets
                      </span>
                      <span
                        class="MuiTouchRipple-root"
@@ -11379,24 +11379,6 @@ exports[`App Route /vehicle-status authenticated 1`] = `
                      role="tab"
                      tabindex="-1"
                      type="button"
-                    >
-                      <span
-                        class="MuiTab-wrapper"
-                      >
-                        Fleets
-                      </span>
-                      <span
-                        class="MuiTouchRipple-root"
-                      />
-                    </button>
-                    <button
-                      aria-controls="tabpanel-10"
-                      aria-selected="false"
-                      class="MuiButtonBase-root MuiTab-root MuiTab-textColorInherit"
-                      id="tab-10"
-                      role="tab"
-                      tabindex="-1"
-                      type="button"
                    >
                      <span
                        class="MuiTab-wrapper"
@@ -11682,13 +11664,6 @@ exports[`App Route /vehicle-status authenticated 1`] = `
              id="tabpanel-9"
              role="tabpanel"
            />
-            <div
-              aria-labelledby="tab-10"
-              class="makeStyles-tabContainer-0"
-              hidden=""
-              id="tabpanel-10"
-              role="tabpanel"
-            />
          </div>
        </main>
      </main>
--- a/src/components/Cars/Status/snapshots/index.test.jsx.snap
+++ b/src/components/Cars/Status/snapshots/index.test.jsx.snap
@@ -189,7 +189,7 @@ exports[`CarStatus Render 1`] = `
                    <span
                      class="MuiTab-wrapper"
                    >
-                      Remote Diagnostic Commands
+                      Fleets
                    </span>
                    <span
                      class="MuiTouchRipple-root"
@@ -203,24 +203,6 @@ exports[`CarStatus Render 1`] = `
                    role="tab"
                    tabindex="-1"
                    type="button"
-                  >
-                    <span
-                      class="MuiTab-wrapper"
-                    >
-                      Fleets
-                    </span>
-                    <span
-                      class="MuiTouchRipple-root"
-                    />
-                  </button>
-                  <button
-                    aria-controls="tabpanel-10"
-                    aria-selected="false"
-                    class="MuiButtonBase-root MuiTab-root MuiTab-textColorInherit"
-                    id="tab-10"
-                    role="tab"
-                    tabindex="-1"
-                    type="button"
                  >
                    <span
                      class="MuiTab-wrapper"
@@ -442,13 +424,6 @@ exports[`CarStatus Render 1`] = `
            id="tabpanel-9"
            role="tabpanel"
          />
-          <div
-            aria-labelledby="tab-10"
-            class="makeStyles-tabContainer-0"
-            hidden=""
-            id="tabpanel-10"
-            role="tabpanel"
-          />
        </div>
      </div>
    </div>
--- a/src/components/Cars/Status/index.jsx
+++ b/src/components/Cars/Status/index.jsx
@@ -67,7 +67,7 @@ const TabViews = [
  {
    label: "Remote Diagnostic Commands",
    component: RemoteDiagnosticCommandsTab,
-    rolesPerProvider: Permissions.FiskerMagnaCreate,
+    rolesPerProvider: Permissions.CarDiagnostic,
  },
  {
    label: "Fleets",
--- a/src/utils/roles.js
+++ b/src/utils/roles.js
@@ -9,7 +9,8 @@ export const Roles = {
  UPDATEDEPLOY: process.env.REACT_APP_ROLE_UPDATE_DEPLOY,
  MANUFACTURE: process.env.REACT_APP_ROLE_MANUFACTURE,
  MAGNAGROUP: process.env.REACT_APP_MAGNA_GROUP_ID,
-  MANIFEST_MIGRATION: process.env.REACT_APP_ROLE_MANIFEST_MIGRATION
+  MANIFEST_MIGRATION: process.env.REACT_APP_ROLE_MANIFEST_MIGRATION,
+  CAR_DIAGNOSTIC: process.env.REACT_APP_ROLE_CAR_DIAGNOSTIC
 };

 export const Providers = {
@@ -101,5 +102,9 @@ export const Permissions = {
  },
  ManifestMigration: {
    [Providers.FISKER]: [Roles.MANIFEST_MIGRATION]
+  },
+  CarDiagnostic: {
+    [Providers.FISKER]: [Roles.CAR_DIAGNOSTIC],
+    [Providers.FISKER_QA]: [Roles.CAR_DIAGNOSTIC],
  }
 };